From f52d59d771dc231fc2ac39adacf157ddefc97730 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sigbj=C3=B8rn=20Skj=C3=A6ret?= Date: Mon, 31 Mar 2025 11:07:07 +0200 Subject: [PATCH] llava : fix clip loading GGUFs with missing description (#12660) --- examples/llava/clip.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/examples/llava/clip.cpp b/examples/llava/clip.cpp index 58ee5cf0..2254b306 100644 --- a/examples/llava/clip.cpp +++ b/examples/llava/clip.cpp @@ -1396,14 +1396,16 @@ struct clip_ctx * clip_init(const char * fname, struct clip_context_params ctx_p const int n_kv = gguf_get_n_kv(ctx); const int ftype = get_u32(ctx, KEY_FTYPE); const std::string ftype_str = get_ftype(ftype); - const int idx_desc = get_key_idx(ctx, KEY_DESCRIPTION); - const std::string description = gguf_get_val_str(ctx, idx_desc); const int idx_name = gguf_find_key(ctx, KEY_NAME); if (idx_name != -1) { // make name optional temporarily as some of the uploaded models missing it due to a bug const std::string name = gguf_get_val_str(ctx, idx_name); LOG_INF("%s: model name: %s\n", __func__, name.c_str()); } - LOG_INF("%s: description: %s\n", __func__, description.c_str()); + const int idx_desc = get_key_idx(ctx, KEY_DESCRIPTION); + if (idx_desc != -1) { // ditto + const std::string description = gguf_get_val_str(ctx, idx_desc); + LOG_INF("%s: description: %s\n", __func__, description.c_str()); + } LOG_INF("%s: GGUF version: %d\n", __func__, gguf_get_version(ctx)); LOG_INF("%s: alignment: %zu\n", __func__, gguf_get_alignment(ctx)); LOG_INF("%s: n_tensors: %d\n", __func__, n_tensors);